Author Topic: MSR *WILL* be finished, come hell or high water... hell more likely.  (Read 34103 times)

Mathius

  • Hero Member
  • *****
  • Posts: 6008
Re: MSR is finished!
« Reply #120 on: September 24, 2011, 11:07:42 AM »
Dodged a bullet there. :)
F@ck Ebay Club member since 2010
Switch Friend Code: SW-2346-3388-5406

Bonknuts

  • Hero Member
  • *****
  • Posts: 3292
Re: MSR is finished!
« Reply #121 on: September 24, 2011, 03:27:42 PM »
Nailed it... found the exact line causing problems, and it was indeed a strcpy() function call... so yeah, it was library code, and out of my control. I have to rewrite this portion of the subprogram to eliminate the strcpy() calls. It may introduce a tiny amount of palette snow but at this point, I really don't give a snot if there's just a touch of it.

 So it was strcpy()? Did you figured out what specifically is causing it to crash inside the lib code?

grahf

  • Hero Member
  • *****
  • Posts: 880
Re: MSR is finished!
« Reply #122 on: September 24, 2011, 03:34:12 PM »
Just put my order in, finally. 
Take your time on those bugs, we can wait.

nodtveidt

  • Guest
Re: MSR is finished!
« Reply #123 on: September 24, 2011, 04:09:21 PM »
So it was strcpy()? Did you figured out what specifically is causing it to crash inside the lib code?
It looks like it wasn't respecting the end-of-string marker and just kept on going, creating an infinite loop. It looks like it's not working anyway, so I'm going to cut out all strcpy() function calls and do a revised version of the code that was there previously.

Thanks for your support, grahf! And everyone else too! :D

Arkhan

  • Hero Member
  • *****
  • Posts: 14142
  • Fuck Elmer.
    • Incessant Negativity Software
Re: MSR is finished!
« Reply #124 on: September 24, 2011, 06:24:21 PM »
I thought I already told you strcpy is f*cked up, lol.

Glad you figured it out, but yeah, shits be busted.  Welcome to HuC.
[Fri 19:34]<nectarsis> been wanting to try that one for awhile now Ope
[Fri 19:33]<Opethian> l;ol huge dong

I'm a max level Forum Warrior.  I'm immortal.
If you're not ready to defend your claims, don't post em.

ParanoiaDragon

  • Hero Member
  • *****
  • Posts: 4619
Re: MSR is finished!
« Reply #125 on: September 24, 2011, 07:03:55 PM »

touko

  • Hero Member
  • *****
  • Posts: 953
Re: MSR is finished!
« Reply #126 on: September 24, 2011, 09:47:03 PM »
It looks like it wasn't respecting the end-of-string marker and just kept on going, creating an infinite loop. It looks like it's not working anyway, so I'm going to cut out all strcpy() function calls and do a revised version of the code that was there previously.

Thanks for your support, grahf! And everyone else too! :D

I have the same problem with strcpy() ..
It seems don't care about EOF .

I have wrote my own, with special EOF/EOL caracter in my txt file.
« Last Edit: September 25, 2011, 05:50:13 AM by touko »

nodtveidt

  • Guest
Re: MSR is finished!
« Reply #127 on: September 25, 2011, 03:13:37 AM »
I have the same problem with strcpy() ..
It seems don't take care about EOF .

I have wrote my own, with special EOF/EOL caracter in my txt file.
Cool, good that you made as workaround for it. Meh... broken stuff sucks. :(

By the way... anyone who's wondering how much work goes into something like this...

The main sourcecode for Toren is 2490 lines of C code. That doesn't include the library header and all of the generic extra inclusions:

sampleheader.h: 2 lines (offset data for the ADPCM sample bank)
campspells.c: 183 lines (selection and display of out-of-battle magics)
common.c: 1429 lines (game engine library code... areas cannot exist without this module)
commontown.c: 239 lines (code only used for towns; primarily shop-related)
bonusfeatures.c: 87 lines (code to handle the system data for unlocking bonus features)

Comes out to about 4430 lines of C. Might be able to cut that down by about 50 for linebreaks between functions and each source's topline comment. This is just one source though... every source is different, as each area has its own unique functions and requirements.

Arm

  • Full Member
  • ***
  • Posts: 123
Re: MSR is finished!
« Reply #128 on: September 25, 2011, 04:46:43 AM »
Hi Rover, just to tell you that the remaining strings you had sent have been translated. You can check your PMs.
« Last Edit: October 01, 2011, 06:40:37 AM by Arm »

nodtveidt

  • Guest
Re: MSR is finished!
« Reply #129 on: September 25, 2011, 05:10:38 AM »
Excellent, thanks Arm... I'll get this inserted right away. :)

Senshi

  • Hero Member
  • *****
  • Posts: 905
Re: MSR is finished!
« Reply #130 on: September 25, 2011, 07:26:55 AM »
Excellent, thanks Arm... I'll get this inserted right away. :)

That's what she said  :P
PSN: Dynastic_Hero
Steam: Dynastic_Hero

Arkhan

  • Hero Member
  • *****
  • Posts: 14142
  • Fuck Elmer.
    • Incessant Negativity Software
Re: MSR is finished!
« Reply #131 on: September 25, 2011, 03:05:09 PM »
all this strcpy madness wouldn't have happened if you made a real game, like Insanity!

SCREW TEXT.  JUST LAZERS.

=3 lol

//trollface.jpg
[Fri 19:34]<nectarsis> been wanting to try that one for awhile now Ope
[Fri 19:33]<Opethian> l;ol huge dong

I'm a max level Forum Warrior.  I'm immortal.
If you're not ready to defend your claims, don't post em.

nodtveidt

  • Guest
Re: MSR is finished!
« Reply #132 on: September 25, 2011, 03:22:11 PM »
Elsie already convinced me to make a Pak-Rat game. :D

Arkhan

  • Hero Member
  • *****
  • Posts: 14142
  • Fuck Elmer.
    • Incessant Negativity Software
Re: MSR is finished!
« Reply #133 on: September 25, 2011, 04:17:27 PM »
lol. I want to remake global thermonuclear war.

Need to make a speech module version!

TURBOBVOICE SYNTHESIS MODULE
[Fri 19:34]<nectarsis> been wanting to try that one for awhile now Ope
[Fri 19:33]<Opethian> l;ol huge dong

I'm a max level Forum Warrior.  I'm immortal.
If you're not ready to defend your claims, don't post em.

touko

  • Hero Member
  • *****
  • Posts: 953
Re: MSR is finished!
« Reply #134 on: September 25, 2011, 08:30:26 PM »
Cool, good that you made as workaround for it. Meh... broken stuff sucks. :(

By the way... anyone who's wondering how much work goes into something like this...

The main sourcecode for Toren is 2490 lines of C code. That doesn't include the library header and all of the generic extra inclusions:

sampleheader.h: 2 lines (offset data for the ADPCM sample bank)
campspells.c: 183 lines (selection and display of out-of-battle magics)
common.c: 1429 lines (game engine library code... areas cannot exist without this module)
commontown.c: 239 lines (code only used for towns; primarily shop-related)
bonusfeatures.c: 87 lines (code to handle the system data for unlocking bonus features)

Comes out to about 4430 lines of C. Might be able to cut that down by about 50 for linebreaks between functions and each source's topline comment. This is just one source though... every source is different, as each area has its own unique functions and requirements.

You can modify original function to correct it ..
I think when you are using strcpy(), it remove \0 at the end of copied string.