HUC - huc_misc.asm file check

[Bonknuts]

Can you guys check your huc_misc.asm file, under the lib2_farmemget.3: label?

Does it read as this?

Code: [Select]

lib2_farmemget.3:

__stw <_cx
 lda <__fbank
 tam #3

 I downloaded a few packages from huc's site and they all have the same error in the lib file.

[TheOldMan]

That's what I have in my huc_misc.asm file.

[touko]

Me too .

[Arkhan]

Me three. 

Are you saying this is an error? lol

[Bonknuts]

Yeah, I pretty sure there's supposed to be a stz <_dl and stz <_dh, right after __stw <_cx. I was given a piece of code for huc that required this, that was written by David Michael that's newer than the last HuC official build. Without this, the function would crash on me (i.e. it was called with left over variables in _dl and _dh).

Should be:

Code: [Select]

lib2_farmemget.3:

__stw <_cx
  stz <_dl
  stz <_dh
  lda <__fbank
  tam #3
 Not sure if farmemget() is listed in the doc or not; there were a few functions that somehow didn't get mentioned in the official doc.

[Arkhan]

I know how they didn't get mentioned.   General carelessness.  I recall reading somewhere, Zeograd ( I think ) flatout said he was too lazy/tired to do documentation, lol.


Maybe it's time HuC finally gets an actual update, like what was supposed to have happened back before I even had 2 lines of Insanity written?

[touko]

I just checked the function, and indeed in some cases it may not work correctly.

Code: [Select]

.t1:  lda <__fptr
 add <_cl
 sta <_al
 lda <__fptr+1
 and #$1F
 adc <_ch
 sta <_ah

cmp #$20  ; if this occur _dx is not initialised
 blo .t2

 ; -- calculate second-half size
 and #$1F
 sta <_dh
 lda <_al
 sta <_dl
 subw <_dx,<_cx
 ; -- remap src ptr
.t2:  lda <__fptr+1
 and #$1F
 ora #$60
 sta <__fptr+1

If code jump to .t2 _dx contains random values,and function may not work properly.

[TheOldMan]

so, let's see if I understand this right..

If you call farmemget() to copy <8k, and it's all in one page (so _dx doesn't get set), when the first part of the (split) copy is done, it will try to copy a random number of bytes (since _dx != 0) from the next page anyway?
wow.

[Bonknuts]

Yeah if the copy length is less than 8k, then it doesn't set or clear _dx (_dl / _dh).


 Arguments for farmemget:

; farmemget(void *dst, far void *base, int len)

"fastcall farmemget(word bx, farptr _fbank:_fptr, word acc)"




A:X hold LEN which gets copied to _CX at the start of the routine. _BX is already written by the fastcall handler. And _fbank:_fptr isn't _DX ($20fe/ff). So it's not like it's a missing parameter or such causing the problem (though huc has special labels for dealing with argument overloading). _DX is a temp 'reg' that didn't get initialized by the start of the function.

[Bonknuts]

Maybe it's time HuC finally gets an actual update, like what was supposed to have happened back before I even had 2 lines of Insanity written?

 Why not? No one is EVER going to update that fork on Zeograd's page. Might as well start our own?

[TheOldMan]

Not with the state the HuC code is in. It would take 6 months just to get the current bugs out, and the code in a state where things could be added.

With that said, Arkhan might (or might not) have a version that accepts c++ comments (//) and a command-line arguement to set the file paths. Others have done similar fixes. Might be worth just trying to get those all together.

[spenoza]

It would take 6 months just to get the current bugs out, and the code in a state where things could be added.

Better to start sooner than later, then. Improving the tools can only improve the quality and number of games made.

[touko]

Better to start sooner than later, then. Improving the tools can only improve the quality and number of games made.

Yes but Better to start later than never ;-)

[dshadoff]

A few things that don't get listed in the documentation are actually omitted because they are not really compatible with the rest of the system.

I don't think that farmemget is one of them, but there were some graphics functions which were basically macros... they didn't get mentioned because they were written in a fast and loose way for demonstration purposes; unfortunately, they messed with registers which aren't supposed to get touched in-between instructions, which had soime bizarre side-effects on otherwise working code.

[nodtveidt]

I would assume that farmemget function was left out of the documentation because explaining to the layman how it works might not be very easy. cd_fade was also left out of the documentation, and the only reason I can assume for that omission is the possibility that whoever wrote the documentation might not have understood the details of its parameter.