As I recall, this was just the difference in how the algorithm worked - same algorithm as Ys IV, but with a different offset. 0x12 also sounds familiar. It's a circular buffer, so doing an "overflow" into the back end of the buffer should also be valid, in the extremely remote chance that a match is actually found.
But the best proof of not blowing up is to encode and decode and verify that the strings match 100%. As I recall, we also did that.
...I just hope that my memory isn't playing tricks on me as I grow older. And you might indeed have found a bug, but it likely wouldn't yield a measurably different compression rate (just the chance of garble as you mention)
Yep, no chance of a crash, just the possibility of garbled data on decompression, depending upon how the ED code actually works on the PCE.
If they're using a 256-byte window buffer, just like you are in the compression, then it probably wouldn't make any difference ... but if they're doing that, then there would be little point in using the 18-minimum-offset in the first place.
The devil-is-in-the-details, and I don't know ... I have no idea where the decompression code is located in ED.
It's just a worry, and not a certainty. As you say, more tests might be a good idea if you're not 100% sure.
Just sayin' ... this 30th Anniversary Year would be a great time to release the translation. :-"
Yes it would.
NightWolve, have you decided to start taking another look at digging into this ?
Now's your time to get into the Sam's queue.
When/while the dub is recorded, he's likely to have some downtime while waiting for things to happen, particularly when I get to the stage of fixing the lipsync.
I know that he'd like to get the Spriggan2 dub luanched, but there may be limits on how far that can go if bonknuts continues to be MIA.
This is a perfect time to push ED forward and get all of his current-finished work inserted and tested and verified so that he'll want to finish-off the rest of the translation.
If other-folks don't keep him busy finishing off these old projects, then I'll have to find some way to keep him busy so that he doesn't get bored!
BTW ... it was interesting to see that person on the NeoGaf forum wax lyrical on some of the PCE RPGs, including Emerald Dragon, and "Angel's Poem".
I had absolutely no idea that that was the English translation of "Tenshi No Uta"!